Skip to content

fix the bug that cannot detect multi qrcode when use_nn_detector is false #3351

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Sep 28, 2022

Conversation

bit1002lst
Copy link
Contributor

@bit1002lst bit1002lst commented Sep 9, 2022

A new PR based on the top of 4.x and fix the conflicts
related issus #3343

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@bit1002lst
Copy link
Contributor Author

I found there is build fail when decode test case [3_close_qrcodes.png].
May I fix this? I cannot find the test image

@bit1002lst
Copy link
Contributor Author

@AleksandrPanov

@AleksandrPanov
Copy link
Contributor

@bit1002lst, 3_close_qrcodes.png (from opencv_extra):

3_close_qrcodes

@bit1002lst
Copy link
Contributor Author

bit1002lst commented Sep 17, 2022

@AleksandrPanov Hello, I have tested this image and recurrent this error.
But, actually, this error is not caused by this PR, because it still exist in top 4.x versions when use_nn_detector is false.

@AleksandrPanov
Copy link
Contributor

@bit1002lst, you broke tests with use_nn_detector = true by adding duplicate qr corners to answer

fixed by this commit: fixed duplicate corners and style

also added test with multi detect

@AleksandrPanov
Copy link
Contributor

@asmorkalov, could you check PR?

@bit1002lst
Copy link
Contributor Author

@bit1002lst, you broke tests with use_nn_detector = true by adding duplicate qr corners to answer

fixed by this commit: fixed duplicate corners and style

also added test with multi detect

Thanks for your help

@AleksandrPanov AleksandrPanov removed their assignment Sep 28, 2022
@asmorkalov asmorkalov merged commit cef9724 into opencv:4.x Sep 28, 2022
@bit1002lst bit1002lst deleted the decode_multi_qrcodes branch September 28, 2022 23:26
@alalek alalek mentioned this pull request Jan 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants