Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/remove admin updatedb #157

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

whatnick
Copy link
Member

  • Completely remove unused updatedb
  • Roll-back update creation-dt a little bit. Can't really get rid of it until there is a scheduled job framework in production.

@tom-butler
Copy link
Contributor

I understand we don't use it, but this is a public helm chart, shouldn't we keep the cron jobs for users that don't have our job framework?

@whatnick
Copy link
Member Author

How would we know if there are other users of this chart ? the update-db and update-creation-dt are copy pasted duplicates and need only one.

@pindge
Copy link
Contributor

pindge commented Jun 22, 2020

Make a note, from version: x.x.x onwards, updateDB is no longer available, please config locally. or something
old version charts will continue to be available

@woodcockr
Copy link
Member

How would we know if there are other users of this chart ? the update-db and update-creation-dt are copy pasted duplicates and need only one.

They will complain and curse you for making the opendatacube community repository into the DEA production repository and thus forcing specific deployment and change management onto them ;-).

It is best to assume it is in use and a) use a deprecation process and/or b) change a major version number on release, tag things and generally do everything in your power to not break existing deployments without notification and the opportunity to pin against a version for when the "others" as ready to update.

@pindge
Copy link
Contributor

pindge commented Jun 22, 2020

I prefer once in a while do a tagged release when the chart is confirmed to be stable and has major changes.

@whatnick whatnick merged commit 1a72e9e into opendatacube:master Jun 23, 2020
@whatnick whatnick deleted the fix/remove-admin-updatedb branch June 23, 2020 03:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants