Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop valid area checks and am-fix 3857. #1635

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

SpacemanPaul
Copy link
Contributor

Reason for this pull request

The valid region check doesn't work because 4326.

Proposed changes

  • Remove the valid region check altogether

  • Allow EPSG's other than 4326 to be anti-meridian corrected if it makes sense. 3857 is the only one I'm aware of that makes sense but there may be others identified later.

  • Resultant test changes.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (f6dff97) to head (8e3622c).
Report is 1 commits behind head on develop-1.9.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1635      +/-   ##
===============================================
- Coverage        85.24%   85.23%   -0.01%     
===============================================
  Files              144      144              
  Lines            15639    15631       -8     
===============================================
- Hits             13331    13323       -8     
  Misses            2308     2308              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review September 18, 2024 22:39
Copy link
Contributor

@Ariana-B Ariana-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I wonder if this might also resolve opendatacube/de_hackathon_2024#9?

Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SpacemanPaul SpacemanPaul merged commit 2510b0d into develop-1.9 Sep 19, 2024
26 checks passed
@SpacemanPaul SpacemanPaul deleted the remove-valid-region-checks branch September 19, 2024 04:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants