Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

extend region timeline overview #388

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

Conversation

pindge
Copy link
Collaborator

@pindge pindge commented Jun 7, 2022

fix #305 and #387

Scope:

  • Add a test product and datasets with regions
  • add assertion test to check product selection menu date displaying only date with datasets
  • add product region date selector filter for the selected region
  • add region summary years count for non-annual product

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #388 (64eaae1) into develop (1af8c56) will increase coverage by 0.12%.
The diff coverage is 97.72%.

@@             Coverage Diff             @@
##           develop     #388      +/-   ##
===========================================
+ Coverage    86.41%   86.54%   +0.12%     
===========================================
  Files           25       25              
  Lines         3121     3158      +37     
===========================================
+ Hits          2697     2733      +36     
- Misses         424      425       +1     
Impacted Files Coverage Δ
cubedash/summary/_extents.py 91.83% <ø> (ø)
cubedash/summary/_model.py 79.77% <ø> (ø)
cubedash/summary/_schema.py 81.51% <ø> (ø)
cubedash/summary/_stores.py 91.89% <97.22%> (+0.33%) ⬆️
cubedash/_model.py 93.38% <100.00%> (ø)
cubedash/_pages.py 87.39% <100.00%> (ø)
cubedash/summary/_summarise.py 96.15% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af8c56...64eaae1. Read the comment docs.

@pindge
Copy link
Collaborator Author

pindge commented Jun 14, 2022

needing some help from sqlalchemy sqlalchemy/sqlalchemy#8131

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeline plot to region view in Explorer
1 participant