-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Parse NCI filepaths to THREDDS location #523
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, though I haven't worked on this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ariana,
Can you please make this an opt-in/configurable option. Explorer isn't only used by DEA, and this change would be most unexpected in other environments. :)
Cheers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #523 +/- ##
===========================================
- Coverage 86.29% 86.24% -0.05%
===========================================
Files 26 26
Lines 3451 3461 +10
===========================================
+ Hits 2978 2985 +7
- Misses 473 476 +3 ☔ View full report in Codecov by Sentry. |
Yes, I expect this would be good to have configurable by a deployment admin. Sharing some ideas, if helpful. If URL converting regexs or functions were imported from As a deployment patch perhaps? Perhaps |
Could we please update this to latest develop to avoid potential |
As per #520
📚 Documentation preview 📚: https://datacube-explorer--523.org.readthedocs.build/en/523/