Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add robots.txt #607

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Add robots.txt #607

merged 3 commits into from
Jun 18, 2024

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Jun 17, 2024 •
edited
Loading

As per #522
As suggested by @omad, provide the contents of robots.txt via deployment config instead of a static file to make updates easier.

📚 Documentation preview 📚: https://datacube-explorer--607.org.readthedocs.build/en/607/

@Ariana-B Ariana-B marked this pull request as draft June 17, 2024 07:21
@Ariana-B Ariana-B marked this pull request as ready for review June 17, 2024 07:29
lars-fillmore
lars-fillmore approved these changes Jun 17, 2024
View reviewed changes
Copy link

@lars-fillmore lars-fillmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd like to test the behavior when AWS CloudFront + WAF is used before releasing this into a production environment

@Ariana-B Ariana-B merged commit 1277ff2 into develop Jun 18, 2024
9 checks passed
@Ariana-B Ariana-B deleted the add_robots_txt branch June 18, 2024 05:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lars-fillmore lars-fillmore lars-fillmore approved these changes

@jeremyh jeremyh Awaiting requested review from jeremyh

@omad omad Awaiting requested review from omad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ariana-B @lars-fillmore