Add PostGIS support #634
Merged
Add PostGIS support #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 11, 2024 07:29
SpacemanPaul
approved these changes
Dec 13, 2024
| pass | ||
|
|
||
|
|
||
| class ExplorerAbstractIndex(ABC): |
There was a problem hiding this comment.
Eventually it would be nice to use this (and the equivalent abstract class in OWS) as a checklist of functionality to be brought into the core index API.
It would therefore be nice if all these methods could have clear docstrings. Probably not worth holding up the 1.9 release over though.
| @@ -100,7 +102,9 @@ def odc_db(postgresql_server, tmp_path_factory, request): | |||
| tmp_path_factory.mktemp("odc") / "test_datacube.conf" | |||
| ) | |||
| config = configparser.ConfigParser() | |||
There was a problem hiding this comment.
With the new config API, it feels like there should be a simpler way to handle test config than dynamically generating a temporary ini file.
There was a problem hiding this comment.
Yeah, this whole setup is copypasta from odc-tools and needs to be revisited
added 7 commits
December 16, 2024 02:48
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the
ExplorerIndexclass to enable PostGIS index support.📚 Documentation preview 📚: https://datacube-explorer--634.org.readthedocs.build/en/634/