-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove checking against crs valid extent #1076
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,7 +168,10 @@ def create_range_entry(layer: OWSNamedLayer, cache: dict[LayerSignature, list[st | |
base_extent = prod_extent | ||
else: | ||
base_extent = base_extent | prod_extent | ||
assert base_extent is not None | ||
if base_extent is None: | ||
click.echo(f"Layer {layer.name} has no extent in CRS {base_crs}. Skipping.") | ||
return | ||
|
||
all_bboxes = bbox_projections(base_extent, layer.global_cfg.crses) | ||
|
||
conn.execute(text(""" | ||
|
@@ -197,19 +200,8 @@ def create_range_entry(layer: OWSNamedLayer, cache: dict[LayerSignature, list[st | |
def bbox_projections(starting_box: odc.geo.Geometry, crses: dict[str, odc.geo.CRS]) -> dict[str, dict[str, float]]: | ||
result = {} | ||
for crsid, crs in crses.items(): | ||
if crs.valid_region is not None: | ||
test_box = starting_box.to_crs("epsg:4326") | ||
clipped_crs_region = (test_box & crs.valid_region) | ||
if clipped_crs_region.wkt == 'POLYGON EMPTY': | ||
continue | ||
clipped_crs_bbox = clipped_crs_region.to_crs(crs).boundingbox | ||
else: | ||
clipped_crs_bbox = None | ||
if clipped_crs_bbox is not None: | ||
result[crsid] = jsonise_bbox(clipped_crs_bbox) | ||
else: | ||
projbbox = starting_box.to_crs(crs).boundingbox | ||
result[crsid] = sanitise_bbox(projbbox) | ||
projbbox = starting_box.to_crs(crs).boundingbox | ||
result[crsid] = sanitise_bbox(projbbox) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can see issues with this, but with the way WMS is defined I'm not sure we can do better. |
||
return result | ||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is a good idea, probably needs testing. Empty products were failing in update ranges though.