Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Maintenance fixes #202

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Maintenance fixes #202

merged 9 commits into from
Feb 7, 2025

Conversation

Kirill888
Copy link
Member

  • Switch to latest pylint and black
  • Mypy fixes for interfacing with shapely
  • fixes for cog to azure tests
  • configure pylint for tests separately from code and remove in-code pylint pragmas

- accept initialized client instead of credentials
- use that to run tests with mocks instead of
  patching that stopped working when imports were
  moved into functions
shapely 2+ has tighter type annotations I guess
- remove pragmas from test code
- add .pylintrc in test folder
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (f6fe191) to head (9fbadf0).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #202      +/-   ##
===========================================
+ Coverage    94.05%   94.91%   +0.86%     
===========================================
  Files           33       33              
  Lines         5649     5663      +14     
===========================================
+ Hits          5313     5375      +62     
+ Misses         336      288      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- fixes for pylint 3 series
Copy link

github-actions bot commented Feb 7, 2025

@github-actions github-actions bot temporarily deployed to pull request February 7, 2025 02:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 7, 2025 02:40 Inactive
- inlcude types for shapely
- use minimal matplotlib
- add azure-storage-blob for az tests
@github-actions github-actions bot temporarily deployed to pull request February 7, 2025 02:46 Inactive
this is to shut up the warning
@github-actions github-actions bot temporarily deployed to pull request February 7, 2025 02:51 Inactive
@Kirill888 Kirill888 merged commit 8b5c56f into develop Feb 7, 2025
20 checks passed
@Kirill888 Kirill888 deleted the cleanz branch February 7, 2025 02:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant