Add disableConnectionTypes feature flag

opendatahub-io · Jul 29, 2024 · 8403e6a · 8403e6a
1 parent 3aeb340
commit 8403e6a
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 0 deletions.
diff --git a/backend/src/types.ts b/backend/src/types.ts
@@ -41,6 +41,7 @@ export type DashboardConfig = K8sResourceCommon & {
       disableArtifactsAPI: boolean;
       disableDistributedWorkloads: boolean;
       disableModelRegistry: boolean;
+      disableConnectionTypes: boolean;
     };
     groupsConfig?: {
       adminGroups: string;

diff --git a/backend/src/utils/constants.ts b/backend/src/utils/constants.ts
@@ -66,6 +66,7 @@ export const blankDashboardCR: DashboardConfig = {
       disableArtifactsAPI: true,
       disableDistributedWorkloads: false,
       disableModelRegistry: true,
+      disableConnectionTypes: true,
     },
     notebookController: {
       enabled: true,

diff --git a/docs/dashboard-config.md b/docs/dashboard-config.md
@@ -34,6 +34,7 @@ The following are a list of features that are supported, along with there defaul
 | disablePerformanceMetrics    | false   | Disables Endpoint Performance tab from Model Serving metrics.                                        |
 | disableDistributedWorkloads  | false   | Disables Distributed Workload Metrics from the dashboard.                                            |
 | disableModelRegistry         | true    | Disables Model Registry from the dashboard.                                                          |
+| disableConnectionTypes       | true    | Disables creating custom data connection types from the dashboard.                                   |
 
 ## Defaults
 

diff --git a/frontend/src/__mocks__/mockDashboardConfig.ts b/frontend/src/__mocks__/mockDashboardConfig.ts
@@ -27,6 +27,7 @@ type MockDashboardConfigType = {
   disableArtifactsAPI?: boolean;
   disableDistributedWorkloads?: boolean;
   disableModelRegistry?: boolean;
+  disableConnectionTypes?: boolean;
   disableNotebookController?: boolean;
   notebookSizes?: NotebookSize[];
 };
@@ -57,6 +58,7 @@ export const mockDashboardConfig = ({
   disableArtifactsAPI = true,
   disableDistributedWorkloads = false,
   disableModelRegistry = true,
+  disableConnectionTypes = true,
   disableNotebookController = false,
   notebookSizes = [
     {
@@ -164,6 +166,7 @@ export const mockDashboardConfig = ({
       disableArtifactsAPI,
       disableDistributedWorkloads,
       disableModelRegistry,
+      disableConnectionTypes,
     },
     notebookController: {
       enabled: !disableNotebookController,

diff --git a/frontend/src/concepts/areas/const.ts b/frontend/src/concepts/areas/const.ts
@@ -29,6 +29,7 @@ export const allFeatureFlags: string[] = Object.keys({
   disableArtifactsAPI: false,
   disableDistributedWorkloads: false,
   disableModelRegistry: false,
+  disableConnectionTypes: false,
 } satisfies DashboardCommonConfig);
 
 export const SupportedAreasStateMap: SupportedAreasState = {
@@ -123,4 +124,7 @@ export const SupportedAreasStateMap: SupportedAreasState = {
     requiredComponents: [StackComponent.MODEL_REGISTRY],
     requiredCapabilities: [StackCapability.SERVICE_MESH, StackCapability.SERVICE_MESH_AUTHZ],
   },
+  [SupportedArea.DATA_CONNECTIONS_TYPES]: {
+    featureFlags: ['disableConnectionTypes'],
+  },
 };
diff --git a/frontend/src/concepts/areas/types.ts b/frontend/src/concepts/areas/types.ts
@@ -61,6 +61,8 @@ export enum SupportedArea {
 
   /* Model Registry areas */
   MODEL_REGISTRY = 'model-registry',
+
+  DATA_CONNECTIONS_TYPES = 'data-connections-types',
 }
 
 /** Components deployed by the Operator. Part of the DSC Status. */

diff --git a/frontend/src/k8sTypes.ts b/frontend/src/k8sTypes.ts
@@ -1239,6 +1239,7 @@ export type DashboardCommonConfig = {
   disableArtifactsAPI: boolean;
   disableDistributedWorkloads: boolean;
   disableModelRegistry: boolean;
+  disableConnectionTypes: boolean;
 };
 
 export type DashboardConfigKind = K8sResourceCommon & {

diff --git a/manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml b/manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml
@@ -75,6 +75,8 @@ spec:
                       type: boolean
                     disableModelRegistry:
                       type: boolean
+                    disableConnectionTypes:
+                      type: boolean
                 groupsConfig:
                   type: object
                   required:

diff --git a/manifests/rhoai/shared/odhdashboardconfig/odhdashboardconfig.yaml b/manifests/rhoai/shared/odhdashboardconfig/odhdashboardconfig.yaml
@@ -28,6 +28,7 @@ spec:
     disableModelMesh: false
     disableDistributedWorkloads: false
     disableModelRegistry: true
+    disableConnectionTypes: true
   groupsConfig:
     adminGroups: "$(admin_groups)"
     allowedGroups: "system:authenticated"