Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

http_server: compatibility fixes for vllm>0.6.1.post1 #136

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Sep 17, 2024

https://issues.redhat.com/browse/RHOAIENG-12997

@dtrifiro dtrifiro force-pushed the http-server-compatibility-fix branch from 43f3678 to e80b3e6 Compare September 17, 2024 08:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.66%. Comparing base (355a088) to head (21b0fce).

Files with missing lines Patch % Lines
src/vllm_tgis_adapter/http.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   56.80%   56.66%   -0.14%     
==========================================
  Files          25       25              
  Lines        1528     1537       +9     
  Branches      277      256      -21     
==========================================
+ Hits          868      871       +3     
- Misses        582      588       +6     
  Partials       78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrifiro dtrifiro force-pushed the http-server-compatibility-fix branch from e80b3e6 to fa286ba Compare September 17, 2024 10:52
@dtrifiro
Copy link
Contributor Author

main branch failing because of vllm-project/vllm#8491. Waiting on vllm-project/vllm#8537 to fix the issue

@njhill
Copy link
Contributor

njhill commented Sep 17, 2024

@dtrifiro the change in question here was made post 0.6.1-post2 i.e. it's not in a release yet. We should be able to move to 0.6.1-post2 without this change.

@dtrifiro dtrifiro merged commit 0ac1b74 into main Sep 23, 2024
2 of 3 checks passed
@dtrifiro dtrifiro deleted the http-server-compatibility-fix branch September 23, 2024 15:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants