fix allowed change ref types environment read #1253

aoteropas · 2023-12-04T08:39:46Z

change the name of the variable in the if clause for the one that contains the env values. Follow the same approach that other Env Variables

Closes #1252

change the name of the variable in the if clause for the one that contains the env values. Follow the same approach that with other Env Variables

BraisVQ · 2023-12-04T10:19:58Z

This change now make Webhook Proxy load the modified parameters but something is not working properly just yet

2023/12/04 10:03:07 zCNVmE Skipping change ref type BRANCH as ALLOWED_CHANGE_REF_TYPES does not include it
2023/12/04 10:03:59 PFYwTB -----
2023/12/04 10:03:59 PFYwTB Skipping change ref type TAG as ALLOWED_CHANGE_REF_TYPES does not include it

when reading the env variable it is set to lower to unify the values. setting to lower the request information to ensure that comparison works

jafarre-bi

If these values are turned lowercase, allowedChangeRefTypesDefault should also have a lowercase value. Otherwise, the fix looks fine.

Update main.go

fix allowed change ref types environment read

28f3094

change the name of the variable in the if clause for the one that contains the env values. Follow the same approach that with other Env Variables

aoteropas requested review from michaelsauter and oalyman as code owners December 4, 2023 08:39

michaelsauter previously approved these changes Dec 4, 2023

View reviewed changes

Update CHANGELOG.md

13c933e

aoteropas dismissed michaelsauter’s stale review via 13c933e December 4, 2023 09:25

BraisVQ self-requested a review December 4, 2023 10:18

set to lower the request chage type to match the one stored

e66e2ec

when reading the env variable it is set to lower to unify the values. setting to lower the request information to ensure that comparison works

jafarre-bi approved these changes Dec 5, 2023

View reviewed changes

jafarre-bi requested changes Dec 5, 2023

View reviewed changes

aoteropas added 3 commits December 5, 2023 11:15

set the default value for change types to lower case

0bcc0a2

Update main.go

1ec94ed

Merge pull request #1 from aoteropas/aoteropas-patch-1

424108d

Update main.go

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix allowed change ref types environment read #1253

fix allowed change ref types environment read #1253

aoteropas commented Dec 4, 2023 •

edited by BraisVQ

Loading

BraisVQ commented Dec 4, 2023

jafarre-bi left a comment

fix allowed change ref types environment read #1253

Are you sure you want to change the base?

fix allowed change ref types environment read #1253

Conversation

aoteropas commented Dec 4, 2023 • edited by BraisVQ Loading

BraisVQ commented Dec 4, 2023

jafarre-bi left a comment

Choose a reason for hiding this comment

aoteropas commented Dec 4, 2023 •

edited by BraisVQ

Loading