Skip to content

fix(hansbug): fix bug of keys, values and items && update unittest #66

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

HansBug
Copy link
Member

@HansBug HansBug commented Jul 14, 2022

import treetensor.torch as ttorch
print(ttorch.Size({'a': [1, 2]}).items())

Will cause error like this

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "treevalue/tree/tree/tree.pyx", line 850, in treevalue.tree.tree.tree.TreeValue.items
  File "treevalue/tree/tree/tree.pyx", line 876, in treevalue.tree.tree.tree.TreeValue.items
TypeError: Argument '_type' has incorrect type (expected type, got _MetaClass)

@HansBug HansBug added the bug Something isn't working label Jul 14, 2022
@HansBug HansBug self-assigned this Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #66 (4aaf82d) into main (74d9375) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          35       35           
  Lines        2152     2152           
=======================================
  Hits         2136     2136           
  Misses         16       16           
Flag Coverage Δ
unittests 99.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
treevalue/tree/tree/tree.pyx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d9375...4aaf82d. Read the comment docs.

@HansBug HansBug merged commit d9354fd into main Jul 14, 2022
@HansBug HansBug deleted the dev/fixmeta branch July 14, 2022 14:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant