Fix evaluation and data pre-processing in EfficientPS

[vniclas]

This PR fixes a couple of issues that have been detected while preparing D8.1:

• fixing the data pre-processing for both KITTI and Cityscapes
• fixing evaluation on the KITTI dataset by introducing specific configuration files

[ad-daniel]

Thank you, I think a mention in the changelog is warranted.
Also I don't believe self.config_file is ever initialized

[vniclas]

Updates:

• Fixed the PEP8 error that caused the linter to fail
• Added the bug fixes to the changelog

The config file is actually being initialized, see line 117 self._cfg = Config.fromfile(config_file).

[ad-daniel]

Ah, my bad. Concerning the failing cppcheck you need to apply this same fix: bcdb7b5 (we applied it on develop but hasn't reached master yet, so this is a good chance to do it)

[ad-daniel]

Forgot to say you need remove the space between: & key or cppcheck complains

[vniclas]

Done.
We should add pre-commit checks for many of the tests. This would prevent most of the failing checks on formatting, PEP8 errors, cppcheck, headers, etc., while being much easier/quicker for the developers.

[ad-daniel]

Thank you!
What do you mean? You don't need to rely on the CI, you can also do the check locally with python -m unittest discover -s tests/sources/ or use addons (like for visualstudio/atom) that do the formatting automatically on save

[vniclas]

Thanks for approving.

Of course, you can set up these things but it would be much more developer-friendly if this is being taken care of automatically and in the same manner for every contributor. I've been using the pre-commit framework in a few other multi-people projects and it simplifies life a lot.
Anyway, I just wanted to draw attention to such tools in case people weren't aware. :)

[ad-daniel]

Anyway, I just wanted to draw attention to such tools in case people weren't aware. :)

Well, I'm one of them, looks quite nice indeed, will look into it!

[vniclas]

Sorry to bother you again @ad-daniel
I just saw a typo in the changelog file and had to fix it.

[passalis]

Thank you!