-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix ros1 video_activity_recognition.py #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Changes seems fine to me.
However, it seems that you are using a different max line width than the 128 characters specified in the OpenDR coding styles and this produced many unrelated changes:
https://github.com/opendr-eu/opendr/wiki/Coding-Style/#cs101-dont-exceed-128-character-for-line-of-code
Also note that there would also be the README.md file to update accordingly:
https://github.com/opendr-eu/opendr/blob/fdd730c0dcb0218b300e8f29e6a5468c8f8c1fdb/projects/opendr_ws/src/perception/README.md
These changes to the README.md have not been merged to develop yet so it would not be optimal to update the README.md in this branch.
So you could add your changes directly in the #316 branch or create a new PR to merge your changes into #316.
Thank you for the comments, @stefaniapedrazzi. As to the README, I'll make sure to update the #316 branch accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LukasHedegaard for the node fixes! Changes look good, apart from some minor comments. Unfortunately, i was not able to run the node due to some errors.
projects/opendr_ws/src/perception/scripts/video_activity_recognition.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/video_activity_recognition.py
Outdated
Show resolved
Hide resolved
…nition.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…nition.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR updates video_activity_recognition.py as described in #281 and addresses #302