Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ros1 fixes heart anomaly detection #330

Merged
merged 12 commits into from
Oct 13, 2022
Merged

Ros1 fixes heart anomaly detection #330

merged 12 commits into from
Oct 13, 2022

Conversation

minhquoc0712
Copy link
Collaborator

Fixed:

  • Update device code selection.
  • Update argparse.
  • Update input and output topic name, and docstring accordingly.

@tsampazk tsampazk self-requested a review October 10, 2022 07:12
@tsampazk tsampazk added the test sources Run style checks label Oct 10, 2022
@tsampazk tsampazk mentioned this pull request Oct 10, 2022
Closed
23 tasks
tsampazk
tsampazk requested changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates in this node, changes look good and the node seems to run smoothly. I have left two very minor comments, and after those it will be good to go!

tsampazk and others added 3 commits October 11, 2022 11:29
@tsampazk
Merge branch 'develop' into ros1-fixes-heart-anomaly-detection
bca0bc4
@minhquoc0712 @tsampazk
Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detect…
6fce6ed 
…ion.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
@minhquoc0712 @tsampazk
Update projects/opendr_ws/src/perception/scripts/heart_anomaly_detect…
8b0358d 
…ion.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
ad-daniel
ad-daniel requested changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a detail, thank you

ad-daniel
ad-daniel approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ad-daniel ad-daniel merged commit ce121ef into develop Oct 13, 2022
@ad-daniel ad-daniel deleted the ros1-fixes-heart-anomaly-detection branch October 13, 2022 08:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tsampazk tsampazk tsampazk approved these changes

@ad-daniel ad-daniel ad-daniel approved these changes

@passalis passalis Awaiting requested review from passalis passalis is a code owner

@omichel omichel Awaiting requested review from omichel omichel is a code owner

@stefaniapedrazzi stefaniapedrazzi Awaiting requested review from stefaniapedrazzi stefaniapedrazzi is a code owner

Assignees
No one assigned
Labels
test sources Run style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minhquoc0712 @tsampazk @ad-daniel