Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ros1 fixes audiovisual emotion recognition #332

Merged
merged 10 commits into from
Oct 13, 2022
Merged

Ros1 fixes audiovisual emotion recognition #332

merged 10 commits into from
Oct 13, 2022

Conversation

minhquoc0712
Copy link
Collaborator

Fixed:

  • Update device code selection.
  • Update argparse.
  • Update input and output topic name, and docstring accordingly.

@minhquoc0712 minhquoc0712 added the test sources Run style checks label Oct 10, 2022
@tsampazk tsampazk self-requested a review October 10, 2022 12:27
@tsampazk tsampazk mentioned this pull request Oct 10, 2022
Closed
23 tasks
@ad-daniel ad-daniel added the test release Tests if a wheel created from a branch runs correctly label Oct 11, 2022
ad-daniel
ad-daniel requested changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ad-daniel ad-daniel removed the test release Tests if a wheel created from a branch runs correctly label Oct 11, 2022
tsampazk
tsampazk requested changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Node looks good, but i get an error when running. I proposed some changes that solved it for me and made the node run smoothly.

@minhquoc0712 minhquoc0712 requested a review from tsampazk October 13, 2022 11:45
@ad-daniel ad-daniel merged commit 6957781 into develop Oct 13, 2022
@ad-daniel ad-daniel deleted the ros1-fixes-audiovisual-emotion-recognition branch October 13, 2022 12:46
@minhquoc0712 minhquoc0712 mentioned this pull request Oct 13, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tsampazk tsampazk tsampazk approved these changes

@ad-daniel ad-daniel ad-daniel approved these changes

@passalis passalis Awaiting requested review from passalis passalis is a code owner

@omichel omichel Awaiting requested review from omichel omichel is a code owner

@stefaniapedrazzi stefaniapedrazzi Awaiting requested review from stefaniapedrazzi stefaniapedrazzi is a code owner

Assignees
No one assigned
Labels
test sources Run style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minhquoc0712 @tsampazk @ad-daniel