ROS1 perception nodes updates #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsampazk
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
ad-daniel
approved these changes
Nov 29, 2022
This was referenced Nov 29, 2022
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multiple fixes mainly regarding comments, prints/#fo, general formatting, argparse shortcuts/consistency/formatting.
I also copied over the changes from the
ros2branch for GEM and DETR, to have all the ros1 nodes updates indevelopand ease the image creation and testing from partners.To make things easier for the reviewers, as soon as this PR gets merged i will be making the remaining global ros fixes regarding ros package naming, file renaming, etc. (let me know in case you want to do this in this PR).
Related to #305