-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Object detection 2d yolov5 #360
Conversation
…r-eu/opendr into object-detection-2d-yolov5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This seems overall fine for me as an inference-only tool. I have only two minor comments.
src/opendr/perception/object_detection_2d/yolov5/yolov5_learner.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
… the model every time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good thank you.
The documentation page should also be referenced in the index.md file, a changelog entry should be added, and a handful of details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vivinousi, the new tool looks good. I have only some minor comments.
projects/python/perception/object_detection_2d/yolov5/inference_tutorial.ipynb
Outdated
Show resolved
Hide resolved
projects/python/perception/object_detection_2d/yolov5/inference_tutorial.ipynb
Outdated
Show resolved
Hide resolved
projects/python/perception/object_detection_2d/yolov5/inference_tutorial.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…e_tutorial.ipynb Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…e_tutorial.ipynb Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Thank you Daniel, I added an entry in the index.md file as well as in the changelog, although I added today's date there which might need to be updated, in ab30d52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for my side, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* DetectionDataset evaluation fix for empty detections * yolov5 initial commit * yolov5 learner cleanup * yolov5 documentation fix * yolov5 demo fix * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> * added force_reload as a parameter for the user to avoid redownloading the model every time * added image size as inference parameter * ROS1 docs update * pep8 fixes * pep8 fixes * added tool to .yml files for testing * fix dependencies * Minor improvements on inference demo * Simple YOLOv5 webcam demo * Minor fix for deprecation warning * Added 'opendr' in node name * Added webcam demo reference in yolov5 readme list * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/object_detection_2d/yolov5/inference_tutorial.ipynb Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/object_detection_2d/yolov5/inference_tutorial.ipynb Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * index + changelog + notebook fixes * Changelog fix Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: ad-daniel <daniel.dias@epfl.ch>
This PR introduces YOLOv5 as an inference-only addition to the toolkit