siamrpn: Single Object tracking 2d #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivinousi
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
vivinousi
added
enhancement
tsampazk
added
test sources
tsampazk
requested changes
Dec 5, 2022
There was a problem hiding this comment.
Thanks @vivinousi for the new tool! Changes LGTM apart from some minor comments.
src/opendr/perception/object_tracking_2d/siamrpn/siamrpn_learner.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_tracking_2d/siamrpn/siamrpn_learner.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_tracking_2d/siamrpn/siamrpn_learner.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_tracking_2d/siamrpn/siamrpn_learner.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/perception/scripts/object_tracking_2d_siamrpn.py
Outdated
Show resolved
Hide resolved
…er.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
… object-tracking-2d-siamrpn
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
# Conflicts: # CHANGELOG.md # projects/opendr_ws/src/opendr_bridge/srv/OpenDRSingleObjectTracking.srv # projects/opendr_ws/src/opendr_perception/CMakeLists.txt # projects/opendr_ws/src/opendr_perception/scripts/object_tracking_2d_siamrpn_node.py
tsampazk
previously approved these changes
Dec 9, 2022
24 tasks
ad-daniel
approved these changes
Dec 12, 2022
tsampazk
approved these changes
Dec 12, 2022
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* SiamRPN learner + ROS node * CRLF -> LF * tests + custom dataset support * changelog update * Update src/opendr/perception/object_tracking_2d/siamrpn/siamrpn_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update docs/reference/rosbridge.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update docs/reference/rosbridge.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/object_tracking_2d/siamrpn/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * fix docs, rename ros1 node, rearrange learner + static methods * fix yolov5 download bug * Update src/opendr/perception/object_tracking_2d/siamrpn/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * dependencies possible fix * dependencies possible fix * update tests to avoid running siamrpn test twice * Some fixes in bridge doc * Minor format fixes * Some more * More details Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> Co-authored-by: ad-daniel <daniel.dias@epfl.ch>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SiamRPN, including a ROS1 node, custom dataset support and three demos