Fix cox3d_learner ONNX support #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHedegaard
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
LukasHedegaard
changed the title
LukasHedegaard
added
test sources
tsampazk
requested changes
Dec 12, 2022
src/opendr/perception/activity_recognition/cox3d/algorithm/res.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/activity_recognition/cox3d/algorithm/res.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/activity_recognition/cox3d/cox3d_learner.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Yes I think we don't expect the algorithms to follow all the constraints we impose for our tools, especially considering that these algorithms might evolve so it might end up just complicating keeping them up to date. As long as the test sources passes (or the location is skipped when running the test) it should be fine IMHO. |
ad-daniel
requested changes
Dec 12, 2022
Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
…nto fix-co3d-onnx
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Update CoX3D with continual-inference based impl * Update implementation with proper onnx support * Update CHANGELOG * Fix x3d learner tests * Update src/opendr/perception/activity_recognition/cox3d/algorithm/res.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/activity_recognition/cox3d/cox3d_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/activity_recognition/cox3d/algorithm/res.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> * Fix typos Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation overhaul for the Continual X3D learner, which uses the continual-inference library to create proper ONNX export and inference for step-wise model operation.