Fall and wave detection ROS nodes #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges are published in both modes
stefaniapedrazzi
requested changes
Apr 11, 2023
projects/opendr_ws/src/opendr_perception/scripts/fall_detection_node.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/opendr_perception/scripts/fall_detection_node.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws_2/src/opendr_perception/opendr_perception/wave_detection_node.py
Show resolved
Hide resolved
|
Thanks for the review @stefaniapedrazzi, i applied your suggestions and i will now resolve the conflicts that arose by merging the performance PR. I will also add the performance stuff to the fall detection nodes. |
tsampazk
added
test sources
projects/opendr_ws/src/opendr_perception/scripts/fall_detection_node.py
Outdated
Show resolved
Hide resolved
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Overhauled fall detection node to be able to run on pose messages * Added to_ros_box in bridge, needed for overhauled fall detection node * Updated fall detection node section * Minor fix ros1 fall node * Added to_rox_box in ros2 bridge * Updated ros2 fall detection node * Initial version of ros1 wave detection node * Renamed class * Added performance to ros1 wave detection node * Minor fixes in fall_detection_node.py * Refactored wave_detection_node.py to work similar to fall detection node * Applied minor fixes to ros2 fall_detection_node.py * Removed unused import * Fall detection ros1 - visualization mode now publishes bboxes too * Fall detection ros2 - visualization mode now publishes bboxes too, fixed bug * Fall detection ros1 doc minor updates * Fall detection ros2 doc updated for newly updated node * Wave detection ros1, added missing docstring and wave detection messages are published in both modes * Added wave detection entry in node index list * Added wave detection section entry and fixed minor thing in fall detection section * Fixed broken link * Added ros2 wave detection node entry in setup.py * Added new ros2 wave detection node * Fixed broken link * Added wave detection entry in node index list * Added wave detection section entry and fixed minor thing in fall detection section * Removed unused import * Fixed default ctor argument and simplified if/else as suggested by review * Fixed default ctor argument as suggested by review * Fixed default ctor argument as suggested by review * Fixes as suggested by review * Re-arranged docstring to match actual order of arguments * Added performance to fall detection ROS1 node * Fixed performance topic name * Added performance topic arg entries for wave and fall detection nodes * Re-arranged docstring to match actual order of arguments * Added performance to fall detection ROS2 node * Added performance topic arg entries for wave and fall detection nodes * Fixed wrong publisher argument in ros2 wave/fall nodes * Fixed fall_detection_node.py performance measurement * Fixed wave_detection_node.py performance measurement * Fixed ROS2 fall_detection_node.py performance measurement * Fixed ROS2 wave_detection_node.py performance measurement
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauled fall detection ROS1/2 nodes to work both by subscribing to an image topic and running pose estimation internally (original mode) and by subscribing to a pose topic and only running fall detection (new mode). Performance stuff is not added in this PR, but will get merged together with #419, i expect some conflicts as the merge is not straightforward, but i will handle it when it comes up.
Added wave detection ROS1/2 nodes that work similar to the new fall detection nodes. The wave detection method used is similar to the one used in the Lightweight OpenPose wave detection demo. Performance is added in this PR as the node is new.
Additionally added a new method
to_ros_boxto ROS1/2 bridges to be able to convert single bboxes.TODO:
@thomaspeyrucain