Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: EfficientLPS panoptic segmentation coloring bug #426

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Fix: EfficientLPS panoptic segmentation coloring bug #426

merged 2 commits into from
Apr 11, 2023

Conversation

aselimc
Copy link
Collaborator

@aselimc aselimc commented Apr 4, 2023

EfficientLPS panoptic segmentation tool had a small bug in the panoptic/instance coloring. With this PR, it is aimed to be fixed.

@aselimc aselimc added bug Something isn't working test sources Run style checks test tools Test the toolkit methods labels Apr 4, 2023
@aselimc aselimc self-assigned this Apr 4, 2023
tsampazk
tsampazk approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the ROS node, which i as far as i can tell would verify that the colors are indeed ok. To verify, this is what i get:

image

If this looks right to you, the code changes look good to me! Thank you.

@vniclas
Copy link
Collaborator

vniclas commented Apr 6, 2023

Thanks @tsampazk !

@vniclas vniclas merged commit bcb181c into develop Apr 11, 2023
@vniclas vniclas deleted the fix-efficientlps-panoptic-coloring branch April 11, 2023 07:32
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
@aselimc @vniclas
fix(efficientLPS): Fix the coloring bug in the panoptic segmentation …
ae0a2d8 
…tool (opendr-eu#426)

Co-authored-by: Niclas <49001036+vniclas@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tsampazk tsampazk tsampazk approved these changes

@stefaniapedrazzi stefaniapedrazzi stefaniapedrazzi approved these changes

@passalis passalis Awaiting requested review from passalis passalis is a code owner

@omichel omichel Awaiting requested review from omichel omichel is a code owner

@ad-daniel ad-daniel Awaiting requested review from ad-daniel

Assignees

@aselimc aselimc

Labels
bug Something isn't working test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aselimc @vniclas @stefaniapedrazzi @tsampazk