Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix tests on master branch #438

Merged
merged 7 commits into from
Jun 6, 2023
Merged

Conversation

stefaniapedrazzi
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi commented Jun 5, 2023

Errors with mobile_manipulation test where probably a consequence of issues with packages installation (solved in #431).
Other than re-enabling the mobile manipulation tests I also tried to improve the code so that it runs package-specific code only when needed.

@stefaniapedrazzi stefaniapedrazzi added test sources Run style checks test tools Test the toolkit methods labels Jun 5, 2023
@stefaniapedrazzi stefaniapedrazzi self-assigned this Jun 5, 2023
@stefaniapedrazzi stefaniapedrazzi added test sources Run style checks test tools Test the toolkit methods and removed test sources Run style checks test tools Test the toolkit methods labels Jun 5, 2023
@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review June 6, 2023 06:29
Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@stefaniapedrazzi
Copy link
Collaborator Author

@passalis you added a comment instead of reviewing the PR 😉

@passalis
Copy link
Collaborator

passalis commented Jun 6, 2023

@passalis you added a comment instead of reviewing the PR wink

Ha ha sorry, I haven't yet had my morning coffee 😆

@stefaniapedrazzi stefaniapedrazzi merged commit dab9ed1 into master Jun 6, 2023
@stefaniapedrazzi stefaniapedrazzi deleted the hotfix-mobile-manipulation-test branch June 6, 2023 07:11
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
* Setup for mobile_manipulation only when testing the package

* Re-enable mobile manipulation test

* Update tests_suite.yml

* Update tests_suite_develop.yml

* Debug just 2 tests

* Update tests_suite.yml

* Update tests_suite_develop.yml
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants