Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FSeq2-NMS #442

Merged
merged 144 commits into from
Sep 1, 2023
Merged

FSeq2-NMS #442

merged 144 commits into from
Sep 1, 2023

Conversation

charsyme
Copy link
Collaborator

Implementation of the FSeq2-NMS method (for person detection only) using SSD as detector.

@charsyme charsyme marked this pull request as draft June 28, 2023 06:56
@charsyme charsyme marked this pull request as ready for review August 22, 2023 21:50
@charsyme
Copy link
Collaborator Author

This PR is ready for review.

tsampazk
tsampazk requested changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @charsyme I have some comments, most are minor inconsistencies between the docs and code and some other details.

src/opendr/perception/object_detection_2d/nms/seq2seq_nms/seq2seq_nms_learner.py Outdated Show resolved Hide resolved
docs/reference/object-detection-2d-nms-fseq2_nms.md Outdated Show resolved Hide resolved
docs/reference/object-detection-2d-nms-fseq2_nms.md Outdated Show resolved Hide resolved
docs/reference/object-detection-2d-nms-fseq2_nms.md Outdated Show resolved Hide resolved
docs/reference/object-detection-2d-nms-fseq2_nms.md Outdated Show resolved Hide resolved
docs/reference/object-detection-2d-nms-seq2seq_nms.md Outdated Show resolved Hide resolved
src/opendr/perception/object_detection_2d/nms/fseq2_nms/README.md Outdated Show resolved Hide resolved
src/opendr/perception/object_detection_2d/nms/fseq2_nms/fseq2_nms_learner.py Outdated Show resolved Hide resolved
...r/perception/object_detection_2d/nms/fseq2_nms/algorithm/__pycache__/__init__.cpython-38.pyc Outdated Show resolved Hide resolved
...erception/object_detection_2d/nms/fseq2_nms/algorithm/__pycache__/fseq2_model.cpython-38.pyc Outdated Show resolved Hide resolved
@tsampazk
Copy link
Collaborator

@charsyme Please double-check if the suggestions are valid and batch commit them through the github UI for conveniency.

charsyme and others added 16 commits August 31, 2023 11:35
@charsyme @tsampazk
Update src/opendr/perception/object_detection_2d/nms/seq2seq_nms/seq2…
1fdc6be 
…seq_nms_learner.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
@charsyme @tsampazk
Update docs/reference/object-detection-2d-nms-fseq2_nms.md
2d0b8b7 
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
@charsyme @tsampazk
Apply suggestions from code review
ede884f 
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
@charsyme
Delete src/opendr/perception/object_detection_2d/nms/fseq2_nms/algori…
98fec87 
…thm/__pycache__ directory
@charsyme
Update fseq2_nms_learner.py
a13ed9f
@charsyme
Update seq2seq_nms_learner.py
90fc72c
@charsyme
Update seq2seq_nms_learner.py
b79e5ba
@charsyme
Update fseq2_nms_learner.py
54de994
@charsyme
Update test_seq2seq_nms.py
4e6a294
@charsyme
Update test_fseq2_nms.py
8f6f818
@charsyme
Update test_fseq2_nms.py
6e88e1a
@charsyme
Update test_seq2seq_nms.py
27c18f0
@charsyme
Update test_seq2seq_nms.py
52d44bf
@charsyme
Update test_fseq2_nms.py
15549d5
@charsyme
Update seq2seq_nms_learner.py
c00fdea
@charsyme
Update fseq2_nms_learner.py
23bf7cd
@charsyme
Copy link
Collaborator Author

charsyme commented Sep 1, 2023

@tsampazk I think I dealt with all the suggestions/comments. Sorry for some extra separate commits.

tsampazk
tsampazk approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charsyme, looks good to me! 👌

passalis
passalis approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@passalis passalis merged commit 6cf2bbf into develop Sep 1, 2023
@passalis passalis deleted the fseq2_nms branch September 1, 2023 07:48
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
@charsyme @tsampazk @passalis
FSeq2-NMS (opendr-eu#442)
2f4d087 
* Add files via upload

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update soft_nms.py

* Update cluster_nms.py

* Update cluster_nms.py

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update fast_nms.py

* Update cluster_nms.py

* Update fast_nms.py

* Add files via upload

* Update __init__.py

* Update ssd_learner.py

* Update README.md

* Add files via upload

* Update fseq2_nms_learner.py

* Update fseq2_nms_learner.py

* Update fseq2_nms_learner.py

* Update nms_dataset.py

* Update __init__.py

* Update nms_dataset.py

* Update eval_demo.py

* Update eval_demo.py

* Update eval_demo.py

* Add files via upload

* Delete projects/python/perception/object_detection_2d/nms/seq2seq-nms directory

* Update eval_demo.py

* Update fseq2_nms_learner.py

* Update eval_demo.py

* Update fseq2_nms_learner.py

* Update train_demo.py

* Update ssd_learner.py

* Update fseq2_nms_learner.py

* Update inference_demo.py

* Update README.md

* Update README.md

* Add files via upload

* Update seq2seq_nms_learner.py

* Update fseq2_nms_learner.py

* Update ssd_learner.py

* Update README.md

* Update README.md

* Update ssd_learner.py

* Update ssd_learner.py

* Add files via upload

* Update test_seq2seq_nms.py

* Update README.md

* Create README.md

* Create object-detection-2d-nms-fseq2_nms.md

* Update object-detection-2d-nms-fseq2_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update object-detection-2d-nms-seq2seq_nms.md

* Update eval_demo.py

* Update object-detection-2d-nms-fseq2_nms.md

* Update object-detection-2d-nms-fseq2_nms.md

* Update object-detection-2d-nms-fseq2_nms.md

* Update nms_dataset.py

* Add files via upload

* Update test_seq2seq_nms.py

* Update nms_dataset.py

* Update README.md

* Update test_seq2seq_nms.py

* Update test_fseq2_nms.py

* Update src/opendr/perception/object_detection_2d/nms/seq2seq_nms/seq2seq_nms_learner.py

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

* Update docs/reference/object-detection-2d-nms-fseq2_nms.md

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

* Delete src/opendr/perception/object_detection_2d/nms/fseq2_nms/algorithm/__pycache__ directory

* Update fseq2_nms_learner.py

* Update seq2seq_nms_learner.py

* Update seq2seq_nms_learner.py

* Update fseq2_nms_learner.py

* Update test_seq2seq_nms.py

* Update test_fseq2_nms.py

* Update test_fseq2_nms.py

* Update test_seq2seq_nms.py

* Update test_seq2seq_nms.py

* Update test_fseq2_nms.py

* Update seq2seq_nms_learner.py

* Update fseq2_nms_learner.py

---------

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tsampazk tsampazk tsampazk approved these changes

@passalis passalis passalis approved these changes

@omichel omichel Awaiting requested review from omichel omichel is a code owner

@stefaniapedrazzi stefaniapedrazzi Awaiting requested review from stefaniapedrazzi stefaniapedrazzi is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charsyme @tsampazk @passalis