Refactoring: pythonic joins in test_clang_format.py/test_cppcheck.py #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosemml
requested review from
passalis,
omichel and
stefaniapedrazzi
as code owners
|
It seems that the test-sources are taking forever, do you know why? |
|
Thanks @tosemml for the improvement! It seems that there are some pep8 indentation issues in the code you modified according to the tests.
The label was actually missing, i added it and approved the run. |
tsampazk
approved these changes
Aug 24, 2023
tsampazk
changed the title
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
…pendr-eu#455) * use join * use join * use join * Fixing under-indented error --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These slight code adjustments aim to enhance Pythonic quality by incorporating the str.join function.