Active_demo and some minor bug fixes on FaceRecognition #459

Pavlos-Tosidis · 2023-09-04T08:32:15Z

Changed Face Recognition inference return. Now class is 0/1 if not found/found
Added feature_extraction method to get access to features from a face image
Added active_demo in which features in database get updated with new features of the same person.

…und/found Added feature_extraction method to get access to features from a face image Added active_demo in which features in database get updated with new features of the same person.

omichel

From source tests, it seems there are some PEP8 errors, please check and fix them.

tsampazk · 2023-09-04T11:35:02Z

This is pretty weird, the ~~PEP8 tests fail~~ at unrelated files from other tools with deprecation warnings for invalid escape characters in regex strings. Maybe these files were excluded from tests earlier, as they are in /algorithm directories.

Edit: these are warnings, they don't fail the tests 😄

src/opendr/perception/face_recognition/face_recognition_learner.py

thomaspeyrucain · 2023-10-11T09:24:19Z

Hello @Pavlos-Tosidis,

I am testing the tool and sometimes I get this error:

[ERROR] [1697016110.932028]: bad callback: <bound method FaceRecognitionNode.callback of <__main__.FaceRecognitionNode object at 0x7fcdc1274550>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/thomaspeyrucain/Desktop/OpenDR/opendr_pal_use_case/projects/opendr_ws/src/opendr_perception/scripts/face_recognition_node.py", line 180, in callback
    self.recognizer.database[result.description].append(features_to_compare)
AttributeError: 'Tensor' object has no attribute 'append'

passalis · 2023-11-06T10:56:39Z

@Pavlos-Tosidis There seems to be pep8 errors still.

* Finetuned yolov5 for trucks (#476) * Yolov5 learner truck updates * Yolov5 create an inference demo for the finetuned model * Update object-detection-2d-yolov5.md yolov5_learner.py documentation for download method * Update object-detection-2d-yolov5.md * Refactor yolov5_learner.py download process in constructor for efficiency * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> --------- Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Yolov5 trucks fixes (#487) * Some fixes and additions on the yolov5 download method doc * Minor addition for model name yolov5 trucks * Some fixes for the yolov5 download method docstring --------- Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

A simple demo for active feature updates A RosNode to be used by Pal_Robotics for the healthcare use case Fixed pep8 errors Added Readme's

Fixed pep8 errors

passalis · 2023-11-24T11:28:22Z

Thanks @Pavlos-Tosidis! Is this ready for review?

Pavlos-Tosidis · 2023-11-24T11:54:34Z

Yes this is ready to be reviewed

Pavlos-Tosidis

Fixed pep8 errors

tsampazk

Thank you @Pavlos-Tosidis for the new features! I have left some comments.

A general note: in all modified/new files, the retinaface detector is initialized with mnet which if i recall correctly is used to identify masked faces. Is this intented?

projects/opendr_ws/src/opendr_perception/README.md

projects/opendr_ws/src/opendr_perception/scripts/active_face_recognition_node.py

src/opendr/perception/face_recognition/face_recognition_learner.py

…ecognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

…r.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

passalis

Thank you!

tsampazk

Thank you!

Comments resolved.

* Changed Face Recognition inference return. Now class is 0/1 if not found/found Added feature_extraction method to get access to features from a face image Added active_demo in which features in database get updated with new features of the same person. * Added final carriage return * Develop (opendr-eu#489) * Finetuned yolov5 for trucks (opendr-eu#476) * Yolov5 learner truck updates * Yolov5 create an inference demo for the finetuned model * Update object-detection-2d-yolov5.md yolov5_learner.py documentation for download method * Update object-detection-2d-yolov5.md * Refactor yolov5_learner.py download process in constructor for efficiency * Update docs/reference/object-detection-2d-yolov5.md Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> --------- Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Yolov5 trucks fixes (opendr-eu#487) * Some fixes and additions on the yolov5 download method doc * Minor addition for model name yolov5 trucks * Some fixes for the yolov5 download method docstring --------- Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Added: A simple demo for active feature updates A RosNode to be used by Pal_Robotics for the healthcare use case Fixed pep8 errors Added Readme's * Added: Fixed pep8 errors * Update projects/opendr_ws/src/opendr_perception/scripts/active_face_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/face_recognition/face_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com> Co-authored-by: Vasilis Moustakidis <45403400+BillMousta@users.noreply.github.com> Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

Changed Face Recognition inference return. Now class is 0/1 if not fo…

fe9e22f

…und/found Added feature_extraction method to get access to features from a face image Added active_demo in which features in database get updated with new features of the same person.

Pavlos-Tosidis requested review from passalis, omichel and stefaniapedrazzi as code owners September 4, 2023 08:32

Added final carriage return

81c1a25

tsampazk added test sources Run style checks test tools Test the toolkit methods labels Sep 4, 2023

omichel requested changes Sep 4, 2023

View reviewed changes

omichel previously requested changes Sep 4, 2023

View reviewed changes

src/opendr/perception/face_recognition/face_recognition_learner.py Outdated Show resolved Hide resolved

src/opendr/perception/face_recognition/face_recognition_learner.py Outdated Show resolved Hide resolved

Pavlos-Tosidis removed test sources Run style checks test tools Test the toolkit methods labels Sep 18, 2023

Merge branch 'develop' into Active_FaceRecognition

649cdfc

passalis added test sources Run style checks test tools Test the toolkit methods labels Nov 6, 2023

passalis and others added 5 commits November 15, 2023 08:05

Merge branch 'develop' into Active_FaceRecognition

206fa07

Added:

3cb6b10

A simple demo for active feature updates A RosNode to be used by Pal_Robotics for the healthcare use case Fixed pep8 errors Added Readme's

Added:

c5001fd

Fixed pep8 errors

Merge branch 'develop' into Active_FaceRecognition

10e48e3

Pavlos-Tosidis requested a review from omichel November 24, 2023 11:53

Pavlos-Tosidis commented Nov 24, 2023

View reviewed changes

tsampazk self-requested a review November 24, 2023 11:57

tsampazk requested changes Nov 24, 2023

View reviewed changes

Pavlos-Tosidis and others added 2 commits November 24, 2023 16:01

Update projects/opendr_ws/src/opendr_perception/scripts/active_face_r…

980eba4

…ecognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

Update src/opendr/perception/face_recognition/face_recognition_learne…

1254706

…r.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

Merge branch 'develop' into Active_FaceRecognition

ce9025c

passalis approved these changes Nov 29, 2023

View reviewed changes

tsampazk approved these changes Nov 29, 2023

View reviewed changes

Merge branch 'develop' into Active_FaceRecognition

f9fb2b7

passalis merged commit f2d4a78 into develop Nov 29, 2023
12 checks passed

passalis deleted the Active_FaceRecognition branch November 29, 2023 09:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Active_demo and some minor bug fixes on FaceRecognition #459

Active_demo and some minor bug fixes on FaceRecognition #459

Pavlos-Tosidis commented Sep 4, 2023

omichel left a comment

tsampazk commented Sep 4, 2023 •

edited

Loading

thomaspeyrucain commented Oct 11, 2023

passalis commented Nov 6, 2023 •

edited

Loading

passalis commented Nov 24, 2023

Pavlos-Tosidis commented Nov 24, 2023

Pavlos-Tosidis left a comment

tsampazk left a comment

passalis left a comment

tsampazk left a comment

Active_demo and some minor bug fixes on FaceRecognition #459

Active_demo and some minor bug fixes on FaceRecognition #459

Conversation

Pavlos-Tosidis commented Sep 4, 2023

omichel left a comment

Choose a reason for hiding this comment

tsampazk commented Sep 4, 2023 • edited Loading

thomaspeyrucain commented Oct 11, 2023

passalis commented Nov 6, 2023 • edited Loading

passalis commented Nov 24, 2023

Pavlos-Tosidis commented Nov 24, 2023

Pavlos-Tosidis left a comment

Choose a reason for hiding this comment

tsampazk left a comment

Choose a reason for hiding this comment

passalis left a comment

Choose a reason for hiding this comment

tsampazk left a comment

Choose a reason for hiding this comment

tsampazk commented Sep 4, 2023 •

edited

Loading

passalis commented Nov 6, 2023 •

edited

Loading