-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
GPU installation fix #463
Merged
Merged
GPU installation fix #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsampazk
added
test sources
Run style checks
test tools
Test the toolkit methods
labels
Sep 18, 2023
tsampazk
requested review from
passalis,
omichel and
stefaniapedrazzi
as code owners
September 18, 2023 10:24
Closed
Closed
Test failure is unrelated to this PR, more information #462 (comment). |
omichel
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can go ahead and merge this PR now.
passalis
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Added qt5-default, modified torch and detectron2 installation * Modified detectron2 installation in single demo grasp * Added version for torch in hyperparameter tuner * Temporary fix removing tools that conflict with installation * Added pip installation of lark which is required for building ROS2 workspace with colcon * Disable single_demo_grasp test * Disable single demo grasp test --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461
This PR fixes GPU detectron2 and torch installation in install.sh and introduces a temporary fix by removing problematic tools (Continual SLAM and Panoptic Segmentation). Detectron2 installation taken from here (CUDA 11.3) and PyTorch installation taken from here (v1.13.1 -> Linux and Windows -> CUDA 11.6).
GPU installation was tested on
develop
branch with:Installation of Panoptic Segmentation and Continual SLAM fail during building probably due to mismatches between CUDA versions (system 11.2 vs torch 11.6), so install.sh entirely removes their src directories.
Detectron2 installs fine but seems to fail the tests:
Spoiler warning
ERROR: test_single_demo_grasp (unittest.loader._FailedTest)
ImportError: Failed to import test module: test_single_demo_grasp
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/loader.py", line 436, in _find_test_path
module = self._get_module_from_name(name)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
import(name)
File "/home/runner/work/opendr/opendr/tests/sources/tools/control/single_demo_grasp/test_single_demo_grasp.py", line 20, in
from detectron2.modeling import build_model
File "/home/runner/work/opendr/opendr/venv/lib/python3.8/site-packages/detectron2/modeling/init.py", line 2, in
from detectron2.layers import ShapeSpec
File "/home/runner/work/opendr/opendr/venv/lib/python3.8/site-packages/detectron2/layers/init.py", line 3, in
from .deform_conv import DeformConv, ModulatedDeformConv
File "/home/runner/work/opendr/opendr/venv/lib/python3.8/site-packages/detectron2/layers/deform_conv.py", line 11, in
from detectron2 import _C
ImportError: /home/runner/work/opendr/opendr/venv/lib/python3.8/site-packages/detectron2/_C.cpython-38-x86_64-linux-gnu.so: undefined symbol: _ZN2at4_ops5zeros4callEN3c108ArrayRefIlEENS2_8optionalINS2_10ScalarTypeEEENS5_INS2_6LayoutEEENS5_INS2_6DeviceEEENS5_IbEE
Temporarily disabled single demo grasp tests.
Any suggestions and/or independent testing are welcome.