Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix fmpgmapping #472

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix fmpgmapping #472

merged 1 commit into from
Oct 24, 2023

Conversation

joseab10
Copy link
Collaborator

Fixed a bug when publishing the full posterior map where the comparison for the map model was done with the wrong enums, leading to publishing the wrong initial alpha and beta parameters for uninformed priors.

This caused the full posterior map to get the wrong initial alpha and beta parameters for uninformed priors.
@vniclas vniclas changed the base branch from master to develop October 23, 2023 06:27
@vniclas vniclas added test sources Run style checks test tools Test the toolkit methods bug Something isn't working labels Oct 23, 2023
Copy link
Collaborator

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.
Thank you.

Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@passalis passalis merged commit 924bda4 into develop Oct 24, 2023
56 of 60 checks passed
@passalis passalis deleted the fix_fmpgmapping branch October 24, 2023 07:59
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
This caused the full posterior map to get the wrong initial alpha and beta parameters for uninformed priors.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants