RL--based Learner for Active Face Recognition #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavlos-Tosidis
requested review from
passalis,
omichel and
stefaniapedrazzi
as code owners
Pavlos-Tosidis
added
enhancement
…n/tester.py removed extra file
…learner_fr_and_pose
tsampazk
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Thank you @Pavlos-Tosidis for the new tool! I added several comments about some fixes. One general comment that i also noted in the readme doc, is that it would be helpful to add a demo.py file that runs a simple evaluation (or similar) loop, so a user can run this out-of-the-box following the documentation and seeing a trained agent in action, without the need to create their own demo file.
...tion/active_perception/active_face_recognition/simulation/worlds/active_face_recognition.wbt
Show resolved
Hide resolved
...endr/perception/active_perception/active_face_recognition/active_face_recognition_learner.py
Show resolved
Hide resolved
...endr/perception/active_perception/active_face_recognition/active_face_recognition_learner.py
Outdated
Show resolved
Hide resolved
...endr/perception/active_perception/active_face_recognition/active_face_recognition_learner.py
Outdated
Show resolved
Hide resolved
Ignored num_steps for eval() but fixed num_episodes logic. Implemented suggestions on ReadME
Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
omichel
requested changes
Nov 8, 2023
passalis
changed the title
minor fixes on README
…learner_fr_and_pose
minor fixes on README
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* Active_fr * Active_fr * Active_fr * Fixes and ReadME * Fixes * Fixes and ReadME * Delete src/opendr/perception/active_perception/active_face_recognition/tester.py removed extra file * Fixes and ReadME * Attempted merge fix for continual * Removed some prints * Face images for database creation * Eval fix * Fixed suggestions by Kostas. Ignored num_steps for eval() but fixed num_episodes logic. Implemented suggestions on ReadME * Added demo under projects * Added demo under projects and corresponding README * Blank lines on demos * Blank lines on demos * Update docs/reference/active_face_recognition.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Fixed Webots version on protos files, minor fixes on README * Fixed Webots version on protos files, minor fixes on README --------- Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Active Face Recognition agent. The implementation relies on stable_baselines3 and trains on Webots.
A Webots world is provided and the corresponding environment file to train an agent in the task of Active Face Recognition, in which the goal is to maximize FR confidence while controlling a Mavic2 drone