Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(metrics): Refactoring metrics package with prometheus metrics naming convention #64

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

mynktl
Copy link
Contributor

@mynktl mynktl commented Jul 13, 2021

Changes:

Signed-off-by: mayank mayank.patel@mayadata.io

Signed-off-by: mayank <mayank.patel@mayadata.io>
@mynktl mynktl requested a review from mittachaitu July 13, 2021 11:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #64 (42c3f36) into develop (0efaba2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #64   +/-   ##
========================================
  Coverage    45.17%   45.17%           
========================================
  Files           27       27           
  Lines         2240     2240           
========================================
  Hits          1012     1012           
  Misses        1158     1158           
  Partials        70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0efaba2...42c3f36. Read the comment docs.

Signed-off-by: mayank <mayank.patel@mayadata.io>
Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants