fix(linkprops): update link props #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlasdairSwan
commented
Jun 3, 2019
| @@ -40,6 +40,7 @@ | |||
| "@commitlint/config-angular": "^6.0.2", | |||
| "@commitlint/prompt": "^6.0.2", | |||
| "@commitlint/prompt-cli": "^6.0.2", | |||
| "@edx/edx-bootstrap": "^2.2.1", | |||
There was a problem hiding this comment.
NB: this is necessary to run the footer dev server.
AlasdairSwan
requested review from
douglashall,
davidjoy,
adamstankiewicz and
georgebabey
|
So I'm assuming it didn't "just work" with the |
|
Sorry @douglashall I didn't get around to checking that. In prospectus we need to be able to update the link urls to point to Spanish versions of the pages so we would need this update for that anyway. I also think it makes sense to move all strings to passed in props, as opposed to some passed in and some hard-coded. |
douglashall
approved these changes
Jun 3, 2019
AlasdairSwan
force-pushed
the
alasdair/update-link-sections-to-accept-arrays
branch
3 times, most recently
from
29b14a8
to
3f0e082
Compare
davidjoy
approved these changes
Jun 3, 2019
BREAKING CHANGE move to link arrays and remove strings from component (and thus the need for i18n)
AlasdairSwan
force-pushed
the
alasdair/update-link-sections-to-accept-arrays
branch
from
4ffff24
to
3ab4adf
Compare
adamstankiewicz
approved these changes
Jun 4, 2019
| }} | ||
| copyright="© 2012–2019 edX Inc." | ||
| trademark={( | ||
| <React.Fragment>EdX, Open edX, and MicroMasters are registered trademarks of edX Inc. | 深圳市恒宇博科技有限公司 <a href="http://www.beian.miit.gov.cn">粤ICP备17044299号-2</a></React.Fragment> |
There was a problem hiding this comment.
Personal preference but the shorthand for fragments is great if you have seen it before:
<>
<div />
<div />
</>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE move to link arrays and remove strings from component (and thus the need for i18n).