bug: REST API filter by UUID breaks on some endpoints #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I just ran this PR through the ONC Inferno FHIR test suite and the Condition endpoint is broken for FHIR with this PR. fhirUrl/apis/default/fhir/Condition?patient=uuid will return a 500 error. |
adunsulag
reviewed
Feb 1, 2023
|
@adunsulag Thanks for the review! Pushed change. Can you rerun the test suite? Thanks! |
adunsulag
reviewed
Feb 2, 2023
|
@adunsulag Hello! I pushed a change. Can you try the test suite again? I think that it will work now 🍻 |
|
@adunsulag , would be great to know if you have any update on @IvanJov's request. Thanks in advance! |
|
@adunsulag , can you please point us to someone who can help close it. |
|
Going to dig deeper into this, but pulled the PR and many of the _search POST requests are breaking now in the Inferno test suite for our ONC certification: Also Condition fails completely: |
Fixing ConditionService to handle FHIR use case when puuid is already a TokenSearchField.
style fix... its what I get for live editing on github
adunsulag
changed the title
adunsulag
added
the
developers
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Dear Community, I am representing the project of a Digital health platform developed by Cardo Health AB ( www.cardohealth.com), through the support of my current employer ( NearForm ). We are pleased to contribute some fixes in OpenEMR on behalf of Cardo Health and look forward to continuing to do so in the future.
In this PR there are multiple fixes:
$searchvariable instead of$newSearchChanges proposed in this pull request: