-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: check server capabilities usin the preferred resources endpoint #54
feat: check server capabilities usin the preferred resources endpoint #54
Conversation
Using the preferred resources endpoit allows us to test for specific API groups that contain a specific resource kind, in this case we can test for which API groups that exist and support Ingress. ci: remove git from the docker build context Pass the versio data via build arguments instead of passing the entire git database. This cuts the build context in half. ci: update multi-arch build flow Use the build process from faas-netes to simplify the multi-arch build process. ci: allow pushing to fork ghcr repos ci: push preview images for PRs ci: build multi-arch in paraller for speed Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
With the more fine-grained check, we can invert our preference and safely test and use networking v1 instead of the v1beta1. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
.github/workflows/publish.yaml
Outdated
registry: ghcr.io | ||
username: ${{ env.USER_REPO }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure, but I think for me to kick off a release build and to have this work, the value of env.USER_REPO needs to equal my login account name.
The way to test is to create your own org and fork or move your repo there and kick off a build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
9f78e6f
to
d000f2d
Compare
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
go-version: [1.13.x] | ||
os: [ubuntu-latest] | ||
runs-on: ${{ matrix.os }} | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to the publish as discussed on the call today.
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thank you for the fixes. Could you update the permissions for the release build please before merge?
I loved the testing instructions on this PR. I think you win the award for the best submitter of PRs in the openfaas org. |
Description
Using the preferred resources endpoit allows us to test for specific API
groups that contain a specific resource kind, in this case we can test
for which API groups that exist and support Ingress.
ci: remove git from the docker build context
Pass the versio data via build arguments instead of passing the entire
git database. This cuts the build context in half.
ci: update multi-arch build flow
Use the build process from faas-netes to simplify the multi-arch build
process.
ci: allow pushing to fork ghcr repos
ci: push preview images for PRs
ci: build multi-arch in paraller for speed
Motivation and Context
Closes #51
Closes #44
Improve #50
How Has This Been Tested?
Create the files
cluster.yaml
andtest.yaml
Then, deploy a 1.19 cluster using
and install the test operator
Specifically take note of this log line:
Deploy a 1.22 cluster using
Re-run the tests
The logs now show only one supported API
Note:
I0829 10:07:16.366955 1 main.go:94] cluster supports ingress in: networking.k8s.io/v1
Types of changes
Impact to existing users
None
Checklist:
git commit -s