Fix bug in bootstrap script #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ If the country name is not updated in MANIFEST.in, the correct dependencies will not be installed and the project will not run
sandcha
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Thank you @alexsoble!
I'm not able to see the make install bug on a Mac but it improves the MANIFEST.in and this PR also solves the make build target 😀
openfisca-new-country/build/lib/openfisca_new_country now includes
parameters/andvariables/. It also includestests/but this could be excluded in a futur PR.
sandcha
reviewed
Feb 18, 2020
Co-Authored-By: sandcha <sandcha@users.noreply.github.com>
|
@sandcha Thank you! Your CHANGELOG suggestion looks good to me. 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
MANIFEST.infile when the user runs the bootstrap script.MANIFEST.in, the correct dependencies will not be installed bymake installand the project will not run.make serve-local(new command!) built, installed, and ran the project without issues; testing the same on the master branch resulted in an error.