You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If anything is done out of order, however, custom handlers are not tracked. This includes, for example, if the plugins are loaded before creating the ForceField:
This might sound like an esoteric case but downstream developers might want to know which plugins are available prior to creating a force field and this is unexpected behavior.
I think this is due to an interaction with all_subclasses:
>>>fromopenff.toolkit.typing.engines.smirnoffimportParameterHandler>>>fromopenff.toolkit.utils.utilsimportall_subclasses>>>fromopenff.toolkit.typing.engines.smirnoff.pluginsimportload_handler_plugins>>>assertload_handler_plugins()[0] inParameterHandler.__subclasses__() # does not raise
This is a private attribute but one I'd like to behave more in line with expectations.
The text was updated successfully, but these errors were encountered:
Describe the bug
The logic I introduced in #1467 only works if its call to
load_handler_plugins
is the first one.To Reproduce
The simple behavior, which works fine, is
If anything is done out of order, however, custom handlers are not tracked. This includes, for example, if the plugins are loaded before creating the
ForceField
:This might sound like an esoteric case but downstream developers might want to know which plugins are available prior to creating a force field and this is unexpected behavior.
I think this is due to an interaction with
all_subclasses
:This is a private attribute but one I'd like to behave more in line with expectations.
The text was updated successfully, but these errors were encountered: