-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace ParmEd with Interchange in Amber/GROMACS example #1113
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
3cbe2f3
Add Interchange + GROMACS to existing GROMACS example
mattwthompson 325a35b
Overhaul Amber + GROMACS example
mattwthompson a964ae6
Update conda env used by binder
mattwthompson f594cd4
Refactor protein-ligand examples to not use ParmEd
mattwthompson dd28d08
Add back ParmEd-based example
mattwthompson 72d8352
Fix other files
mattwthompson fdf19b9
Rename notebooks
mattwthompson 7b353f9
Add header notes to each notebook
mattwthompson 6df34eb
add new example deps to example yaml
j-wags 70cd142
Skip Interchange example when AmberTools is not installed
mattwthompson 9b126ea
Merge remote-tracking branch 'upstream/drop-parmed-examples' into dro…
mattwthompson cc4b1e0
Do not assume LAMMPS and GROMACS are installed
mattwthompson 9b9d823
Fix how GROMACS/Amber notebook is detected
mattwthompson 109641d
Merge remote-tracking branch 'upstream/master' into drop-parmed-examples
mattwthompson 23d674f
Debug files
mattwthompson 5b26465
Move debug so it might get printed
mattwthompson eca429d
Split out Amber/GROMACS example into earlier step
mattwthompson 511a445
Run examples with Python 3.9
mattwthompson 618bc7b
try not using mamba in case its causing trouble with ambertools
j-wags db9f186
re enable mamba, force ambertools downgrade
j-wags 637eae9
Try running it as a test script
mattwthompson 2283dfe
Merge remote-tracking branch 'upstream/drop-parmed-examples' into dro…
mattwthompson f7e2d3b
Unpin AmberTools
mattwthompson 64c4af2
Revert some debugging in workflow
mattwthompson 7219b0b
Remove script used for debugging
mattwthompson 5363f56
Pin to interchange v0.1.3+
mattwthompson e7466a4
Merge branch 'master' into drop-parmed-examples
mattwthompson f41cee6
Update CHANGELOG
mattwthompson 8d62b9f
Merge remote-tracking branch 'upstream/drop-parmed-examples' into dro…
mattwthompson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be explicit: I will include this branch into a release before aiming to have this PR merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now included in v0.1.3; CI will need to be restarted next week to get it to pass (the package will not be online until after hours)