Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support version 0.4 of SMIRNOFF Electrostatics section #1277

Merged
merged 18 commits into from
May 6, 2022

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Apr 20, 2022

Resolves #1084 in part

Fixes #1288

  • Blocked by OFF-EP 0005b standards#34
  • Add up-converters
  • Test up-converters
  • Handle switch_width in electrostatics handler Do not handle, but explicitly do not handle
  • Band-aid old code paths?
  • Update Interchange - I'd like to do this after this PR to avoid too many feature branches being split off
  • Tag issue being addressed
  • Add tests
  • Update docstrings/documentation, if applicable - I did a scan for .method and similar patterns and didn't find anything obviously outdated.
  • Lint codebase
  • Update changelog

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1277 (1d7e1d7) into topology-biopolymer-refactor (8128d0b) will decrease coverage by 2.54%.
The diff coverage is 96.05%.

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I hammered on this a bit and it looks like everything works well. The only thing this PR still needs to add the solvent_dielectric ParameterAttribute required in the 0.4 Electrostatics spec. Per the spec, it should default to "none", and it's fine if we have the setter just raise a NotImplementedError if someone tries to set it to anything else.

Also (per inline comment) I don't think we should even try to support unexpected 0.3 methods - It would be fine if anything fishy just raises an error.

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - Thanks @mattwthompson! Feel free to merge once tests pass.

@mattwthompson mattwthompson merged commit 0107544 into topology-biopolymer-refactor May 6, 2022
@mattwthompson mattwthompson deleted the prep-off-ep-0005b branch May 6, 2022 02:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants