Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Register parameter handler class alongside handler #1476

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Register parameter handler class alongside handler #1476

merged 3 commits into from
Nov 30, 2022

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Nov 29, 2022 •
edited
Loading

Resolves #1475

@codecov
Copy link

codecov bot commented Nov 29, 2022 •
edited
Loading

Codecov Report

Merging #1476 (55dbe1e) into main (1dd4251) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

j-wags
j-wags approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Please update the releasehistory before you merge :-)

@mattwthompson mattwthompson marked this pull request as ready for review November 30, 2022 17:52
@mattwthompson mattwthompson merged commit 989c5f6 into main Nov 30, 2022
@mattwthompson mattwthompson deleted the register-parameter-handler-class branch November 30, 2022 18:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ForceField._parameter_handler_classes not updated when registering handlers
2 participants
@mattwthompson @j-wags