Update versioneer #1749
Merged
Update versioneer #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
LGTM, though it's hard to test locally that it works with 3.12
$ git checkout upstream/py312-versioneer && python setup.py version
HEAD is now at b3160794 Update versioneer
running version
keywords are unexpanded, not using
got version from VCS {'version': '0.14.4+6.gb3160794', 'full-revisionid': 'b31607946861791d6465439629f2025ab7eb1f9e', 'dirty': False, 'error': None, 'date': '2023-10-19T13:43:54+1100'}
Version: 0.14.4+6.gb3160794
full-revisionid: b31607946861791d6465439629f2025ab7eb1f9e
dirty: False
date: 2023-10-19T13:43:54+1100
|
The examples CI failures are unrelated. Thanks @mattwthompson and @Yoshanuikabundi! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Versioneer to 0.29 for Python 3.12 support.