Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow writing molecules to paths #1826

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Allow writing molecules to paths #1826

merged 3 commits into from
Apr 11, 2024

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Feb 15, 2024 •
edited by j-wags
Loading

#740

@mattwthompson mattwthompson mentioned this pull request Feb 15, 2024
Merged
5 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

Merging #1826 (6887415) into main (dde9469) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 6887415 differs from pull request most recent head 413c645. Consider uploading reports for the commit 413c645 to get more accurate results

Additional details and impacted files

@mattwthompson mattwthompson changed the title Use paths in fixtures, allow writing molecules to paths Allow writing molecules to paths Apr 11, 2024
@mattwthompson
Copy link
Member Author

I previously wanted to update how molecule data is parsed in tests, but something mysterious is going on that I can't figure out so I'm ditching that altogether.

@mattwthompson mattwthompson marked this pull request as ready for review April 11, 2024 19:51
j-wags
j-wags approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll update releasenotes and merge.

@j-wags j-wags merged commit c00d7a7 into main Apr 11, 2024
15 of 17 checks passed
@j-wags j-wags deleted the use-pathy-fixtures branch April 11, 2024 23:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags