Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Topology.clear_positions #1827

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Add Topology.clear_positions #1827

merged 3 commits into from
Mar 11, 2024

Conversation

mattwthompson
Copy link
Member

This adds Topology.clear_positions() which does what the name implies, instead of allowing Topology.set_positions(None) as I originally advocated for in #1820. Today I think it's better to just have a separate method that does this one thing - it handles what I remember my use case to be - instead of allowing set_positions to take different types.

I hold this preference weakly (I've already changed my mine once on my own) and can easily be talked out of it

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #1827 (0fb80b0) into main (118918c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review February 22, 2024 20:14
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks @mattwthompson!

@j-wags j-wags merged commit bba866c into main Mar 11, 2024
18 checks passed
@j-wags j-wags deleted the clear-positions branch March 11, 2024 17:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants