-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Resolve #1842 by setting OMP_NUM_THREADS=2 in toolkit showcase #1846
Conversation
j-wags
commented
Mar 25, 2024
•
edited
Loading
edited
- Resolves The toolkit showcase stochastically fails with OMP_NUM_THREADS=1 and AmberToolsToolkitWrapper #1842 (doesn't solve the issue that certain combinations of molecule + n_cores + rdkit version + ambertools version leads to something going wrong in sqm, but at least gets examples CI running for another few months until we can replace this whole stack with NAGL)
- Add tests
- Update docstrings/documentation, if applicable
- Lint codebase
- Update changelog
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
…ith OMP_NUM_THREADS=1
The original error was "charge assignment fails in I've tried reproducing this error in CI in this PR, locally on my M1 mac, and in a linux/amd64 docker container on the same mac. The only sqm failures I've seen are in macos/rdkit CI builds on this PR:
(note that the failures in the openff-docs builds were linux/rdkit, NOT the macos/rdkit ones that I'm getting here) I think this means the error is stochastic and may not actually be based on atom ordering or OS. I'm toying with the idea of having the AmberTools charge assignment pathway generate two conformers and try the second one if the first fails. On one hand, the behavior change would seem acceptable here, since it changes a random error into a valid outcome. On the other, it takes a relatively long time to fail on one conformer (~5-10 mins) and if there were a legitimate problem with the input then this change would double the the amount of time before the user got an error message. So, I'm unsure here. I'll talk with @Yoshanuikabundi on Monday to determine if there's some way to more consistently reproduce the error so we can have a better grasp on options moving forward. |
If the number of threads/cores/solar flares is important, it would be useful to work that into the error message. The current failures are heavily obfuscated by the |