Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip slow CI in nightly runs until failures can be debugged #2004

Closed
wants to merge 12 commits into from

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Jan 29, 2025

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (74cfe94) to head (927278a).
Report is 2 commits behind head on main.

Additional details and impacted files

@mattwthompson
Copy link
Member

If you haven't already considered it, the lowest-friction starting point might be to revert the relevant subset of #1970, i.e. move the Pytest config back to setup.cfg. But there have been some mysterious things going on in adjacent spaces so that might not fix it. (I'd love to see most of the slow tests go away altogether, but that's a bigger change)

@j-wags
Copy link
Member Author

j-wags commented Feb 7, 2025

Thanks for the input. It would take me a while to tease apart #1970 into the minimal changes to revert to advance this, so my current thinking is to temporarily disable the slow tests so that nightlies regain some of their utility, and add a high-priority ticket to the backlog to debug and re-enable them.

@j-wags j-wags changed the title [DNM] Try to reproduce scheduled CI errors Skip slow CI in nightly runs until they can be debugged Feb 7, 2025
@j-wags j-wags changed the title Skip slow CI in nightly runs until they can be debugged Skip slow CI in nightly runs until failures can be debugged Feb 7, 2025
@j-wags j-wags marked this pull request as ready for review February 7, 2025 22:22
@j-wags j-wags mentioned this pull request Feb 7, 2025
@j-wags
Copy link
Member Author

j-wags commented Feb 11, 2025

#2017 is a better solution

@j-wags j-wags closed this Feb 11, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants