-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reduce Travis verbosity and remove most LGTM issues #258
Conversation
This pull request introduces 1 alert and fixes 61 when merging a8205cc into 0b4c523 - view on LGTM.com new alerts:
fixed alerts:
Comment posted by LGTM.com |
This pull request fixes 61 alerts when merging a3c1ad2 into 0b4c523 - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 73.1% 74.78% +1.67%
==========================================
Files 17 17
Lines 5128 5012 -116
==========================================
- Hits 3749 3748 -1
+ Misses 1379 1264 -115
Continue to review full report at Codecov.
|
Wow, awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Test verbosity is much better now.
Thank you! |
Fix #234 and remove almost all LGTM issues. The remaining LGTM issues are related to
environment.py
, which we're not sure if it will kept around, andgbsaforces.py
, which I believe is still largely unsupported.