Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add registered_parameter_handlers property to ForceField #632

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

mattwthompson
Copy link
Member

Resolves #369 and makes it I don't have to do for handler_name in ff._parameter_handlers.keys(): ... when trying to splice out individual ParameterHandler objects in a force field that was passed to the system

There is a potentially-more-elegant solution proposed in the issue; this is the easier approach

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #632 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwthompson mattwthompson merged commit ae756fc into master Jul 6, 2020
@mattwthompson mattwthompson deleted the add-registered-parameter-handlers branch May 25, 2021 19:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ForceField.registered_handler_names (Add handy handling of handlers)
3 participants