-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix deployment tests, skip tests requiring optional dependencies #818
Conversation
This link is probably not persistent, but the failing check is fixed and the tests are passing so far: https://github.com/openforcefield/openff-toolkit/runs/1729531265?check_suite_focus=true |
To clarify, this PR does two things
# 1 will work before a release, but # 2 will not work until the next release because this action checks out the most recent commit. But at least the tests will run, and only fail for a small set of known "failures." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and the test_molecule
changes are really nice too. For the tests where OE and RDKit gave insignificantly different results (eg different precisions), I've changed them to be separate tests. Thanks, @mattwthompson!
This PR fixes a small typo in the deployment tests (that would have been quite difficult to see ahead of time in #803). This is contained to just this workflow; the release is not broken. When comparing git tags, the runner steps up one directory before running
git ls-remote
to find the tag of the cloned repo, which is then compared to the version found in the Python package. This check works fine and passes. But when going back into the repo, it needs to beopenff-toolkit
, notopenff/toolkit
. So this line is an exception to the general pattern of which path needs to be stepped into.I'll see if I can run the workflow from this branch to be sure it works.