Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set default style to vector layers in GEE #590

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Set default style to vector layers in GEE #590

merged 5 commits into from
Sep 12, 2022

Conversation

dfguerrerom
Copy link
Collaborator

As mentioned in #425, gee vector layers were not using the default style, with this PR, we will have this as a default behavior.

I'm chaging this because apparently it's chaging frequently with every ipyleaflet version. I have randomly taken 5 basemaps and the test will assess if these basemaps are within the list.
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #590 (32f42c7) into main (9e5c958) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 32f42c7 differs from pull request most recent head 648f352. Consider uploading reports for the commit 648f352 to get more accurate results

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   92.21%   92.24%   +0.03%     
==========================================
  Files          38       38              
  Lines        3904     3909       +5     
==========================================
+ Hits         3600     3606       +6     
+ Misses        304      303       -1     
Impacted Files Coverage Δ
sepal_ui/mapping/sepal_map.py 90.96% <100.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dfguerrerom dfguerrerom requested a review from 12rambau September 8, 2022 15:24
Copy link
Member

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the small typo it seems perfect to me.

Co-authored-by: Rambaud Pierrick <12rambau@users.noreply.github.com>
@dfguerrerom dfguerrerom merged commit 4359d45 into main Sep 12, 2022
@12rambau 12rambau deleted the ee_layer_style branch November 17, 2022 05:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants