Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: create a specific aoi_dc on the map #620

Merged
merged 1 commit into from
Nov 25, 2022
Merged

fix: create a specific aoi_dc on the map #620

merged 1 commit into from
Nov 25, 2022

Conversation

12rambau
Copy link
Member

Fix #595

Create a aoi_dc on the fly if a map is specified. This create a duplicate but ensure that if 2 dcs are added to the map, AoiVeiw abject will only manipulate this one.

Fix #595

Create a aoi_dc on the fly if a map is specified. This create a duplicate but ensure that if 2 dcs are added to the map, AoiVeiw abject will only manipulate this one.
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #620 (6409332) into main (21c1b29) will decrease coverage by 0.05%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   92.28%   92.22%   -0.06%     
==========================================
  Files          36       36              
  Lines        3913     3922       +9     
==========================================
+ Hits         3611     3617       +6     
- Misses        302      305       +3     
Impacted Files Coverage Δ
sepal_ui/aoi/aoi_view.py 98.80% <93.75%> (+0.06%) ⬆️
sepal_ui/mapping/draw_control.py 97.56% <100.00%> (ø)
sepal_ui/mapping/sepal_map.py 90.36% <0.00%> (-0.61%) ⬇️
sepal_ui/reclassify/reclassify_model.py 92.33% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@12rambau 12rambau marked this pull request as ready for review November 25, 2022 19:43
@12rambau 12rambau merged commit b501874 into main Nov 25, 2022
@12rambau 12rambau deleted the aoi_dc branch November 25, 2022 19:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if a custom dc is added to a map it is hidden by the AoiView
1 participant