Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fontawesome V6 #645

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Fontawesome V6 #645

merged 2 commits into from
Dec 11, 2022

Conversation

12rambau
Copy link
Member

@12rambau 12rambau commented Nov 29, 2022

  • use fontawesome V6
  • change all the fas and far occurences by fa-solid(res. fa-regular)
  • change the icons that were not free to their free alternative

note
fas will continue to work in v6 for quite some time so application will not need to change everything but their sizing is a bit different.

Fix #576

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #645 (83ad765) into main (8a8196e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files          36       36           
  Lines        3911     3912    +1     
=======================================
+ Hits         3623     3624    +1     
  Misses        288      288           
Impacted Files Coverage Δ
sepal_ui/reclassify/reclassify_view.py 84.46% <ø> (ø)
sepal_ui/reclassify/table_view.py 59.45% <ø> (ø)
sepal_ui/sepalwidgets/inputs.py 100.00% <ø> (ø)
sepal_ui/frontend/styles.py 100.00% <100.00%> (ø)
sepal_ui/mapping/aoi_control.py 100.00% <100.00%> (ø)
sepal_ui/mapping/fullscreen_control.py 100.00% <100.00%> (ø)
sepal_ui/mapping/map_btn.py 100.00% <100.00%> (ø)
sepal_ui/mapping/value_inspector.py 88.99% <100.00%> (ø)
sepal_ui/sepalwidgets/app.py 95.86% <100.00%> (ø)
sepal_ui/sepalwidgets/btn.py 97.05% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@12rambau 12rambau marked this pull request as ready for review November 29, 2022 22:12
@12rambau
Copy link
Member Author

I need this PR to be merged for the conda release. I'm overpassing review checks. Don't hesitate to reach in the issues if needed

@12rambau 12rambau merged commit 5880e2f into main Dec 11, 2022
@12rambau 12rambau deleted the fontawesome branch December 11, 2022 17:03
dfguerrerom added a commit to sepal-contrib/planet_active_fires_explorer that referenced this pull request Jan 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to free tagged icons v.5 on fontawesome?
1 participant